expose sibling method with seed #1
Closed
Roms1383
wants to merge 0 commits from Roms1383:feat/seed
into master
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'Roms1383:feat/seed'
Deleting a branch is permanent. It CANNOT be undone. Continue?
expose seed parameter from crc32.
any update on this @jstrong ?
hey - apologies for the delay in responding, I did not get an alert and didn''t realize this issue existed until now!
Regarding the PR - can you provide "docstring" comment describing the new function which explains what a seed is in this context? I think that would be useful to people looking at the docs initially.
apologies too, I spend most of my time on Github and only noticed your reply yesterday.
looking at the commits it seems this branch is outdated and you already applied the changes: if so, it can probably be closed. also, is the "docstring" still required ?
well - you can just put one here if you know what it should be ... I'll add it ... I published an rc version to crates.io so it would at least exist for you there.
So generally speaking, sometimes providing a seed is useful to guarantee reproductible, deterministic result.
We use
crc32
to generate in-game identifiers for Cyberpunk 2077 modding which, under the hood, uses predefined seed based on identifier type.For example, in the game a TweakDBID uses
0
as its seed.The exact definition can probably be copied from
rand
crate, for example from_seed method.added docstring + tests and published v1.3.0 to crates.io. Thanks for the PR!